[PATCH 0/3] Split up mvsas submission into multiple commits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The following changes are stored on the 'mvsas-split' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git

The submission of Marvell's mvsas driver update was done in an opaque
way, that makes it difficult to see what kinds of changes were applied
to the driver:  drivers/scsi/mvsas.c is deleted, and a new driver with lots of
new code is created inside drivers/scsi/mvsas/

If James will permit, I would suggest REPLACING the scsi-misc-2.6.git commit
from Marvell, 2142d072d858912dfc17e173d8ba66eb60a31c6c, with the following
three commits I have created:

1) Move drivers/scsi/mvsas.c to drivers/scsi/mvsas/mv_sas.c

   _Zero_ code changes, just file movement.

   Driver compiles and works correctly.

2) Split up functions in mv_sas.c into component files
   mv_sas.[ch], mv_init.c, mv_64xx.[ch], mv_chips.h, mv_defs.h.

   _Zero_ functional code changes, just code movement.

   Driver compiles and works correctly.

3) Apply Marvell's changes.

   _Zero_ changes from Marvell's commit.  I did not attempt to fix any
   bugs or address other issues; I merely copied Marvell's submitted
   (and accepted) code on top of my new commit #1 and #2.

   Driver compiles and works correctly.

The goal of my changes here is to greatly ease the strain of reviewing
such a large submission of code.

I have not done an exhaustive comparison of intra-function code blocks; the
best I did was ensure that definitions and functions that existed before
Marvell's commit remained in the same order after Marvell's commit.

These changes were created on top of 

	commit 1bfe9caaff367601134c14fc428017419f628f7d
	Author: James Smart <James.Smart@xxxxxxxxxx>
	Date:   Thu Mar 26 13:33:19 2009 -0400

	    [SCSI] FC Pass Thru support

I strongly recommend pulling the above branch, rather than applying the
patches presented, to preserve full git metadata in the face of a file move.

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux