On Fri, 2009-05-08 at 14:17 +0800, Ying Chu wrote: > - hdr->flags = cpu_to_le32(flags | > - (tei->n_elem << MCH_PRD_LEN_SHIFT) | > - (MCH_SSP_FR_CMD << MCH_SSP_FR_TYPE_SHIFT)); > + if (is_tmf) > + flags |= (MCH_SSP_FR_TASK << MCH_SSP_FR_TYPE_SHIFT); > + hdr->flags = cpu_to_le32(flags | (tei->n_elem << MCH_PRD_LEN_SHIFT)); If is_tmf isn't set, shouldn't we be setting the command frame indicator, like the old code was? (I know it's sort of irrelevant because MCH_SSP_FR_CMD is defined to be zero, so if you're just dumping the definition MCH_SSP_FR_CMD, that's fine too). James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
