On 04/29/2009 09:51 PM, Al Viro wrote: > On Wed, Apr 29, 2009 at 09:26:31AM -0700, Randy Dunlap wrote: >> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx> >> >> Fix printk format warnings in osd_uld: >> >> drivers/scsi/osd/osd_uld.c:191: warning:format '%s' expects type 'char *', but argument 2 has type 'struct path' >> >> Also fix a small typo. > > Applied, will fold on reorder. Thanks for catching that one and apologies > for missing the original posting (I am subscribed to linux-scsi, but...) > > Incidentally, what the hell is going with ->i_cdev in there? Boaz? Thanks for asking. The thing is that this function is called from within the kernel by exofs. Now I have found that if user-mode as never opened an handle on my char-device, then inode->i_cdev is NULL even though it is registered and found. My mount utility for exofs does an open/close on the char-device before calling the Kernel mounter, but this is just a script and can be missed by users. (I guess I need to submit an mount.exofs. where should it be submitted?) Alternatively we perhaps need a udev rule that, one - loads osd.ko when OSD_TYPE devices are discovered by scsi (like sd), and two - do the above open/close. I was meaning to ask someone about these things. Much obliged Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
