On Tue, 2009-04-28 at 13:03 +1000, Stephen Rothwell wrote: > Hi James, > > Today's linux-next build (powerpc ppc64_defconfig gcc4.4.0) produced this > warning (it has for a while): > > drivers/scsi/st.c: In function 'st_int_ioctl': > drivers/scsi/st.c:2967: warning: suggest parentheses around operand of '!' or change '|' to '||' or '!' to '~' > > The code in question: > > STp->use_pf = !STp->use_pf | PF_TESTED; > > looks questionable at best. Yes, I think it should become STp |= PF_TESTED; but I'm not sure, so I'll defer to Kai. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
