On Tue, Apr 28, 2009 at 08:33:46PM -0700, Yinghai Lu wrote: > Matthew Wilcox wrote: > > On Tue, Apr 28, 2009 at 06:02:23PM -0700, Yinghai Lu wrote: > >> dev_set_name(cdev, name); > >> > >> the name become fmt. > > > > Yes, and what happens if 'name' is '%s'? > > > > change > dev_set_name(cdev, name); > to > dev_set_name(cdev, "%s", name); > > didn't fix the problem. > > need to check name && name[0] Yes. There are _two_ problems. You fixed one. James asked if you would fix the other while you're touching that code. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
