RE: [PATCH 1/6] fnic: add main file with module infrastructure,fnic structure, Makefile

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: James Bottomley [mailto:James.Bottomley@xxxxxxxxxxxxxxxxxxxxx] 
> Sent: Monday, April 27, 2009 8:45 AM
> To: Abhijeet Arvind Joglekar (abjoglek)
> Cc: linux-scsi@xxxxxxxxxxxxxxx; Joe Eykholt (jeykholt)
> Subject: Re: [PATCH 1/6] fnic: add main file with module 
> infrastructure,fnic structure, Makefile
> 
> On Fri, 2009-04-17 at 18:32 -0700, Abhijeet Joglekar wrote:
> > fnic_main.c: include module load and unload, PCI device probe, 
> > scsi-ml, libFC and scsi-transport-fc registration and interfaces
> > 
> > fnic.h: has fnic definition and other related data types
> > 
> > Makefile:
> > 
> > Signed-off-by: Abhijeet Joglekar <abjoglek@xxxxxxxxx>
> > Signed-off-by: Joe Eykholt <jeykholt@xxxxxxxxx>
> > Signed-off-by: Mike Christie <michaelc@xxxxxxxxxxx>
> 
> I'm guessing this should be:
> 
> Signed-off-by: Abhijeet Joglekar <abjoglek@xxxxxxxxx>
> Reviewed-by: Joe Eykholt <jeykholt@xxxxxxxxx>
> Acked-by: Mike Christie <michaelc@xxxxxxxxxxx>
> 
> ?
> 
> James
> 

Joe is in the module-author and MAINTAINERS list, so his name should
have "Signed-off-by" tag.

As Mike said in his email, he contributed changes to driver and reviewed
the driver code. I put the "Signed-off-by" tag for Mike as a superset to
include his patch contributions + review. I am ok with the tag that you
and Mike think is appropriate.

thanks
-- abhijeet


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux