double unlock in aac_fib_send()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is from drivers/scsi/aacraid/commsup.c (2.6.30-rc1)
   518                  } else if (down_interruptible(&fibptr->event_wait)) {
   519                          fibptr->done = 2;
   520                          up(&fibptr->event_wait);
   521                  }

down_interruptible() returns zero if it aquires the lock or -EINTR on 
failure.  Since we failed to aquire the lock there is no need to call up() 
on line 520.

Found by smatch (http://repo.or.cz/w/smatch.git).

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux