On Mon, 2009-04-20 at 14:16 +0000, James Bottomley wrote:
> On Mon, 2009-04-20 at 10:56 -0300, Kleber S. Souza wrote:
> > On Fri, 2009-04-17 at 22:05 -0400, James Bottomley wrote:
> > > On Fri, 2009-04-17 at 16:08 -0300, Kleber S. Souza wrote:
> > > > Hi,
> > > >
> > > > Any comments on this patch?
> > > >
> > > > It was acked by Brian King, do I need to do anything else to get it
> > > > accepted?
> > >
> > > No ... looks OK to me:
> > >
> > > > Thanks,
> > > > Kleber
> > > >
> > > > On Mon, 2009-03-23 at 17:12 -0300, Kleber Sacilotto de Souza wrote:
> > > > > Marking the ipr clean up function ipr_remove() as __devexit and using
> > > > > __devexit_p() macro in its address reference.
> > > > >
> > > > >
> > > > > Signed-off-by: Kleber Sacilotto de Souza <kleber@xxxxxxxxxxxxxxxxxx>
> > > > > Signed-off-by: Breno Leitao <leitao@xxxxxxxxxxxxxxxxxx>
> > >
> > > Just explain this signoff? signed-off-by is supposed to document the
> > > hands the patch has passed through ... it's not clear what Breno Leitao
> > > has to do with the transmission of this patch.
> > >
> >
> > Breno Leitão pointed out to me that this change needed to be made based
> > on the kernel documentation <Documentation/PCI/pci.txt>. I wrote the
> > patch, got the ack from Brian King and sent it to the list.
>
> So that should be Reported-by: not Signed-off-by for Breno.
>
> There's no actual ack from Brian King on this email.
>
> James
>
Resending the patch with the proper tags. Sorry for the confusion.
Marking the ipr clean up function ipr_remove() as __devexit and using
__devexit_p() macro in its address reference.
Signed-off-by: Kleber Sacilotto de Souza <kleber@xxxxxxxxxxxxxxxxxx>
Reported-by: Breno Leitao <leitao@xxxxxxxxxxxxxxxxxx>
Acked-by: Brian King <brking@xxxxxxxxxxxxxxxxxx>
---
drivers/scsi/ipr.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
index 0782900..bc39ac6 100644
--- a/drivers/scsi/ipr.c
+++ b/drivers/scsi/ipr.c
@@ -7674,7 +7674,7 @@ static void __ipr_remove(struct pci_dev *pdev)
* Return value:
* none
**/
-static void ipr_remove(struct pci_dev *pdev)
+static void __devexit ipr_remove(struct pci_dev *pdev)
{
struct ipr_ioa_cfg *ioa_cfg = pci_get_drvdata(pdev);
@@ -7850,7 +7850,7 @@ static struct pci_driver ipr_driver = {
.name = IPR_NAME,
.id_table = ipr_pci_table,
.probe = ipr_probe,
- .remove = ipr_remove,
+ .remove = __devexit_p(ipr_remove),
.shutdown = ipr_shutdown,
.err_handler = &ipr_err_handler,
};
--
--
Kleber S. Souza
IBM Linux Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
