Kleber found the problem, debugged it, and provided a fix to me. I provided him with an alternate patch to fix it. I'm assuming this should have been handled by me submitting with my signoff alone and adding a reported-by tag for Kleber. Sorry for the confusion. Shall I resend as I just described? Thanks, Brian James Bottomley wrote: > On Mon, 2009-04-20 at 13:59 -0300, Kleber S. Souza wrote: >> From: Brian King <brking@xxxxxxxxxxxxxxxxxx> >> >> The ipr driver can hang if it encounters enough PCI errors >> to trigger the permanent error handler. The driver will attempt >> to initiate a "bringdown" of the adapter and fail all pending >> ops back. However, this bringdown is unlike any other bringdown >> of the adapter in the code as the driver. In this code path we >> end up failing back ops with allow_cmds still set to 1. This results >> in some commands, the HCAM commands in particular, getting immediately >> re-issued to the adapter on the done call, which results in >> an infinite loop in ipr_fail_all_ops. Fix this by setting allow_cmds >> to zero in this path. >> >> Signed-off-by: Brian King <brking@xxxxxxxxxxxxxxxxxx> >> Signed-off-by: Kleber S. Souza <klebers@xxxxxxxxxxxxxxxxxx> > > OK, now I'm really confused. Originally this patch was your From: but > had a Brian signoff. I asked if it shouldn't be acked by him instead > and he responded "correct". > > Now you've sent the patch as being his original authorship ... whose > patch is this? > > James > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Brian King Linux on Power Virtualization IBM Linux Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
