On Thu, 2009-04-16 at 18:41 -0300, Kleber Sacilotto de Souza wrote: > The ipr driver can hang if it encounters enough PCI errors > to trigger the permanent error handler. The driver will attempt > to initiate a "bringdown" of the adapter and fail all pending > ops back. However, this bringdown is unlike any other bringdown > of the adapter in the code as the driver. In this code path we > end up failing back ops with allow_cmds still set to 1. This results > in some commands, the HCAM commands in particular, getting immediately > re-issued to the adapter on the done call, which results in > an infinite loop in ipr_fail_all_ops. Fix this by setting allow_cmds > to zero in this path. > > Signed-off-by: Brian King <brking@xxxxxxxxxxxxxxxxxx> > Signed-off-by: Kleber Sacilotto de Souza <klebers@xxxxxxxxxxxxxxxxxx> This signoff chain isn't right ... signoffs are supposed to document the hands through which this patch has patched. I take it this should be acked-by Brian King instead? James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html