On Mon, 13 Apr 2009 14:59:12 +0200 Borislav Petkov <petkovbb@xxxxxxxxxxxxxx> wrote: > Hi, > > On Mon, Apr 13, 2009 at 07:07:58PM +0900, FUJITA Tomonori wrote: > > On Mon, 13 Apr 2009 18:38:23 +0900 > > Tejun Heo <tj@xxxxxxxxxx> wrote: > > > > > FUJITA Tomonori wrote: > > > >> I thought that was agreed and done? What is left to do for that to go > > > >> in. > > > > > > > > I've converted all the users (sg, st, osst). Nothing is left. So we > > > > don't need this. > > > > > > Yeah, pulled it. Okay, so we can postpone diddling with request > > > mapping for now. I'll re-post fixes only from this and the previous > > > patchset and proceed with other patchsets. > > > > To be honest, I don't think that we can clean up the block > > mapping. For example, blk_rq_map_kern_prealloc() in your patchset > > doesn't look cleanup to me. It's just moving a hack from ide to the > > block (well, I have to admit that I did the same thing when I > > converted sg/st/osst...). > > Well, since blk_rq_map_kern_prealloc() is going to be used only in > ide-cd (driver needs it to queue a sense request from within the irq > handler) and since it is considered a hack I could try to move it out of > the irq handler It's quite nice if you could do that. But I think that ide-atapi also needs blk_rq_map_kern_prealloc(). > and do away only with blk_rq_map_kern() if that is more > of an agreeable solution? Yeah, blk_rq_map_kern() is much proper. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
