On Thu, Apr 9, 2009 at 11:07, Andrew Patterson <andrew.patterson@xxxxxx> wrote: > On Thu, 2009-04-09 at 10:05 -0700, Kay Sievers wrote: >> The block device needs a parent, please assign the cciss bus device. >> It's the driverfs_dev in the genhd struct. >> > > This is already done in cciss_add_disk(): > > disk->fops = &cciss_fops; > disk->private_data = &h->drv[drv_index]; > disk->driverfs_dev = &h->drv[drv_index].dev; > > I think my problem is I was assigning cciss_bus_type to the controller, > not the block device. I have fixed that. > # /sbin/udevadm info --attribute-walk "--path=/block/cciss!c0d0" > looking at parent device > '/devices/pci0000:4f/0000:4f:00.0/0000:50:00.0/0000:51:04.0/0000:8b:00.0/cciss0': > KERNELS=="cciss0" > SUBSYSTEMS=="" This device also needs the cciss bus_type assigned, so the subsystem becomes cciss, and it also shows up in /sys/bus/cciss/devices/. Other than that, the sysfs hierarchy looks fine. Thanks, Kay -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html