Re: initialize max_target_blocked in scsi_alloc_target

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Edward Goggin wrote:
Patch 1 of 1

This patch initializes the max_target_blocked field of a scsi target structure
so that a queuecommand return value of SCSI_MLQUEUE_TARGET_BUSY will actually
result in having the scsi_queue_insert blocking the device queue before requeuing
the command and running the queue.  Otherwise, can and does cause livelock on
single CPU configurations if/when open-iSCSI software initiator's command PDU
window fills.

Signed-off-by: Ed Goggin <egoggin@xxxxxxxxxx>

--- linux-2.6.29/drivers/scsi/scsi_scan.c	2009-03-23 19:12:14.000000000 -0400
+++ linux-2.6.29-fix/drivers/scsi/scsi_scan.c	2009-04-09 11:11:01.000000000 -0400
@@ -427,6 +427,7 @@ static struct scsi_target *scsi_alloc_ta
 	INIT_LIST_HEAD(&starget->devices);
 	starget->state = STARGET_CREATED;
 	starget->scsi_level = SCSI_2;
+	starget->max_target_blocked = SCSI_DEFAULT_TARGET_BLOCKED;
  retry:
 	spin_lock_irqsave(shost->host_lock, flags);


Thanks for finding this.

Reviewed-by: Mike Christie <michaelc@xxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux