* Mike Christie (michaelc@xxxxxxxxxxx) wrote: > Ah, ok, I can agree with passing up errors in general. I did the > attached patch to propogate the error code upwards. It does not really > make much difference now. The iscsi pool init caller just checks for > error or no error and does not even print out the error. It will not > make tracing errors easier or more difficult. To be useful, we would > have to propgate the error higher to userspace so the user can see it. I > do not think I have time to get that in the current feature window, so > that would have to wait unless you have patches I can test now. Yup, I think it's just fine as is. > libiscsi: propogate errors from kfifo_init to iscsi_pool_init callers > > Don't convert kfifo_init's error code to -ENOMEM when passing the > error to the iscsi_pool_init caller. > > Signed-off-by: Mike Christie <michaelc@xxxxxxxxxxx> Acked-by: Chris Wright <chrisw@xxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
