On 04/01/2009 08:05 PM, James Bottomley wrote: > On Wed, 2009-04-01 at 20:00 +0300, Boaz Harrosh wrote: >> On 04/01/2009 04:44 PM, Tejun Heo wrote: >>> Impact: hack removal >>> >>> SCSI needs to map sgl into rq for kernel PC requests; however, block >>> API didn't have such feature so it used its own rq mapping function >>> which hooked into block/bio internals and is generally considered an >>> ugly hack. The private function may also produce requests which are >>> bigger than queue per-rq limits. >>> >>> Block blk_rq_map_kern_sgl(). Kill the private implementation and use >>> it. >>> >>> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx> >> James, TOMO >> >> what happened to Tomo's patches that removes all this after fixing up >> all users (sg.c)? >> >> I thought that was agreed and done? What is left to do for that to go >> in. > > They couldn't go in because they would break libosd. You were going to > send patches to fix libosd so it no longer relied on the exported > function ... did that happen and I missed it? > That's not related. I'm asking about the scsi ULD patches and finally the patch to scsi_lib.c. libosd only conflicts with the very last patch to block layer. I don't see how that prevents the cleanups to scsi? And BTW, I did send RFC patches that removes usage of blk_rq_append_bio() and did not receive any comments > James > > Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
