* Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote: > On Wed, 18 Feb 2009, Ingo Molnar wrote: > > > > > * Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote: > > > > > I have no idea if this will make any difference for the > > > problem you're seeing, but it has been submitted and it's > > > worth trying out. If the problem still occurs, I'll write a > > > diagnostic patch to add log messages giving the destiny of > > > each request in scsi_io_completion(). > > > > OK, i've undone the reverts and have applied your fix - it will > > take a few hours to see whether the hang still occurs. > > Any definitive results yet? Yes, as i wrote before, the bug is fixed. > It turns out that the patch I posted earlier is not quite > correct; the "__scsi_release_buffers(cmd, 0);" line in > scsi_end_request() was added after the patch was first written > and then got lost during rebasing. Yeah, rebasing is a really bad idea in general. > If this really does fix your problem and nobody has any other > objections to it, I'll submit a revised version with the > missing line added back in. Sure, no objections. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
