Jean Delvare wrote:
Memory freeing in iscsi_pool_free() looks wrong to me. Either q->pool
can be NULL and this should be tested before dereferencing it, or it
can't be NULL and it shouldn't be tested at all. As far as I can see,
the only case where q->pool is NULL is on early error in
iscsi_pool_init(). One possible way to fix the bug is thus to not
call iscsi_pool_free() in this case (nothing needs to be freed anyway)
and then we can get rid of the q->pool check.
Signed-off-by: Jean Delvare <jdelvare@xxxxxxx>
Acked-by: Mike Christie <michaelc@xxxxxxxxxxx>
James,
If you are scooping up late fixes for 2.6.29-rc, then please take this
if it qualifies. It is not a regression, but a simple bug fix that can
be hit in situations where there is small amounts of memory (for some
reason common in virtual machine setups a lot).
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
