From: Roel Kluin <roel.kluin@xxxxxxxxx> Date: Wed, 18 Feb 2009 13:48:11 +0100 > Add missing parentheses > > Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx> So what bug does this cause? > #define QLOGICPTI_REQ_QUEUE_LEN 255 /* must be power of two - 1 */ > -#define QLOGICPTI_MAX_SG(ql) (4 + ((ql) > 0) ? 7*((ql) - 1) : 0) > +#define QLOGICPTI_MAX_SG(ql) (4 + (((ql) > 0) ? 7*((ql) - 1) : 0)) The "ql > 0" bids to the "?" operator, so this expression does the right thing as-is as far as I can tell. Do you think that "4 + ((ql > 0)" binds to "?", I don't think it does. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html