James Bottomley wrote: > On Wed, 2009-02-18 at 11:08 -0800, Yinghai Lu wrote: >> James Bottomley wrote: >>> On Wed, 2009-02-18 at 10:04 -0800, Andrew Morton wrote: >>> >>>> Do we not need mpt-fix-enable-lsi-sas-to-use-msi-as-default.patch as >>>> well, to fix this regression? >>> No ... it's a separate issue. MSI was enabled for fusion SAS in 2.6.26; >>> the problem msi patch which the above corrects actually has the effect >>> of disabling MSI for fusion and went into 2.6.29-rc2, which isn't a >>> kernel that's been tested here. >>> >> so for 2.6.26, 27, 28 need pci-enable-msi-on-8132.patch > > I'm a bit lost with the names, but if that's the PCI quirk fix, then yes yes > >> 2.6.29 need pci-enable-msi-on-8132.patch and mpt-fix-enable-lsi-sas-to-use-msi-as-default.patch > > Like I said, I'm happy to have MSI completely disabled until LSI wants > to comment, so no ... only the PCI quirk fix. The true fix is to have > the drivers participate in dynamic testing of MSI IRQ routing, but I've > somewhat lost sight of that. [PATCH] mpt: fix enable lsi sas to use msi as default Impact: fix bug the third param in module_param(,,) is perm instead of default value. we still need to assign default at first. Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx> --- drivers/message/fusion/mptbase.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6/drivers/message/fusion/mptbase.c =================================================================== --- linux-2.6.orig/drivers/message/fusion/mptbase.c +++ linux-2.6/drivers/message/fusion/mptbase.c @@ -90,8 +90,8 @@ module_param(mpt_msi_enable_fc, int, 0); MODULE_PARM_DESC(mpt_msi_enable_fc, " Enable MSI Support for FC \ controllers (default=0)"); -static int mpt_msi_enable_sas; -module_param(mpt_msi_enable_sas, int, 1); +static int mpt_msi_enable_sas = 1; +module_param(mpt_msi_enable_sas, int, 0); MODULE_PARM_DESC(mpt_msi_enable_sas, " Enable MSI Support for SAS \ controllers (default=1)"); or you want [PATCH] mpt: fix disable lsi sas to use msi as default Impact: fix bug the third param in module_param(,,) is perm instead of default value. we still need to assign default at first. Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx> --- drivers/message/fusion/mptbase.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6/drivers/message/fusion/mptbase.c =================================================================== --- linux-2.6.orig/drivers/message/fusion/mptbase.c +++ linux-2.6/drivers/message/fusion/mptbase.c @@ -91,9 +91,9 @@ MODULE_PARM_DESC(mpt_msi_enable_fc, " En controllers (default=0)"); static int mpt_msi_enable_sas; -module_param(mpt_msi_enable_sas, int, 1); +module_param(mpt_msi_enable_sas, int, 0); MODULE_PARM_DESC(mpt_msi_enable_sas, " Enable MSI Support for SAS \ - controllers (default=1)"); + controllers (default=0)"); static int mpt_channel_mapping; anyway we need to fix the typo. YH -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
