Re: [PATCH 2.6.29-rc] iscsi - add offset and count to alloc_pdu()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Karen Xie wrote:
[PATCH 2.6.29-rc] iscsi - add offset and count to alloc_pdu().

From: Karen Xie <kxie@xxxxxxxxxxx>

Hi, Mike,

I looked through libiscsi.c, libiscsi_tcp.c and iscsi_tcp.c. It does seem to be a little messy to merge the two functions. Especially the BHS is constructed after pdu_alloc(), and iscsi_tcp uses the BHS fields in init_pdu().
So I only added the offset and count as additional parameters to alloc_pdu(). So that the pdu payload is known at the time of pdu memory allocation.


Ehhhhhh, yeah it is workable. Give me a day to check this out more. It makes the api akward because we get the data offset and len, but not the header. Let me see if I can build on your patch.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux