On Tue, 10 Feb 2009 18:19:33 +0000 James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote: > On Tue, 2009-02-10 at 17:43 +0000, James Bottomley wrote: > > There's a current barrier to this: osd_initiator has also become a > > consumer of blk_rq_append_bio(). > > > > It seems to be emulating block internals, so I think the fix is twofold: > > > > 1. adjust blk_rq_map_kern to call blk_rq_append_bio() instead of > > blk_rq_prep_bio() (with an extra failure path). > > 2. make osd_initiator simply call it for additions. > > > > I can code up a patch to see if it works. > > So this is the patch to allow blk_rq_map_kern to append to requests, > which is what I think is needed. > > Unfortunately unwinding osd_initator's bio dependence and putting it > back on data buffers looks to be a bit of a longer chore. Looks like the osd initiator code uses bio nicely; e.g. using blk_rq_append_bio and bio_map_kern is completely wrong. I'll see the code to fix it... -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
