On Thu, 29 Jan 2009, Harvey Harrison wrote: > The base versions handle constant folding now. Almost entirely > in qla2xxx/qla4xxx. Do the same semantics apply to htonl()? As, I'd rather see the changes from __constant_htonl() -> cpu_to_be32() be __constant_htonl() -> htonl(): ... > diff --git a/drivers/scsi/qla2xxx/qla_dbg.c b/drivers/scsi/qla2xxx/qla_dbg.c > index 34760f8..21a8fe8 100644 > --- a/drivers/scsi/qla2xxx/qla_dbg.c > +++ b/drivers/scsi/qla2xxx/qla_dbg.c > @@ -331,7 +331,7 @@ qla25xx_copy_fce(struct qla_hw_data *ha, void *ptr, uint32_t **last_chain) > return ptr; > > *last_chain = &fcec->type; > - fcec->type = __constant_htonl(DUMP_CHAIN_FCE); > + fcec->type = cpu_to_be32(DUMP_CHAIN_FCE); > fcec->chain_size = htonl(sizeof(struct qla2xxx_fce_chain) + > fce_calc_size(ha->fce_bufs)); > fcec->size = htonl(fce_calc_size(ha->fce_bufs)); ... fcec->type = htonl(DUMP_CHAIN_FCE); fcec->chain_size = htonl(sizeof(struct qla2xxx_fce_chain) + fce_calc_size(ha->fce_bufs)); As it lends itself to a greater level of consistency with the other assignments in the code regions... -- av -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
