On Wed, 28 Jan 2009 01:03:34 +0100 (CET) Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx> wrote: > > FUJITA Tomonori wrote: > >> On Tue, 27 Jan 2009 18:03:40 +0100 (CET) > >> Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx> wrote: > >>> + if (orb->page_table_bus) > >>> + dma_unmap_single(card_device, orb->page_table_bus, > >>> + sizeof(orb->page_table), DMA_TO_DEVICE); > >> > >> Well, this does not look correct since zero can be a valid dma > >> address. > > > From: Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx> > Subject: firewire: sbp2: fix DMA mapping leak on the failure path > > Reported-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> > who also provided a first version of the fix. > > Signed-off-by: Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx> > --- > drivers/firewire/fw-sbp2.c | 27 +++++++++++++++++---------- > 1 file changed, 17 insertions(+), 10 deletions(-) It's time to ask him to test this patch with the default or _less_ swiotlb resource, I guess. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
