On Tue, 2009-01-27 at 10:39 -0500, James Smart wrote: > We were running i/o and performing a bunch of hba resets in a loop. > This forces a lot of target removes and rescans. Since the resets > are occuring during scan it's causing the scan i/o to timeout or fail, > invoking error recovery, etc. We end up getting a nasty crash > in scsi_scan.c due to references to old sdevs that had some > lingering references that kept them around. > > Fix by setting device state to SDEV_DEL if the LLD's slave_alloc > fails. This will fail reference taking in subsequent teardown/scan paths. > > -- james s > > > Signed-off-by: James Smart <james.smart@xxxxxxxxxx> > > --- > > scsi_scan.c | 1 + > 1 file changed, 1 insertion(+) > > > diff -upNr a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c > --- a/drivers/scsi/scsi_scan.c 2009-01-27 09:44:31.000000000 -0500 > +++ b/drivers/scsi/scsi_scan.c 2009-01-27 10:12:04.000000000 -0500 > @@ -310,6 +310,7 @@ static struct scsi_device *scsi_alloc_sd > */ > if (ret == -ENXIO) > display_failure_msg = 0; > + scsi_device_set_state(sdev, SDEV_DEL); A minor nit (since we only have one user of out_device_destroy) is that the state setting should be done in the out_device_destroy: branch James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
