On Mon, 2009-01-12 at 20:41 -0600, Mike Christie wrote: > Mike Christie wrote: > > Nicholas A. Bellinger wrote: > > > >> Ok, I still have my hands full with LIO v3.0 code atm, so I am not sure > >> how soon I could get to this.. > >> > > > > Don't worry about it. I can replicate it here. > > > > Crazy, I guess it is a leak we always had (at least back to 2.6.22 (did > not look firther)), and no one noticed. Here is a patch. I will send it > to James with some other patches I had. > > Thanks for the report. > Thanks Mike!!! --nab > --~--~---------~--~----~------------~-------~--~----~ > You received this message because you are subscribed to the Google Groups "open-iscsi" group. > To post to this group, send email to open-iscsi@xxxxxxxxxxxxxxxx > To unsubscribe from this group, send email to open-iscsi+unsubscribe@xxxxxxxxxxxxxxxx > For more options, visit this group at http://groups.google.com/group/open-iscsi > -~----------~----~----~----~------~----~------~--~--- > > plain text document attachment (libiscsi-fix-pool-queue-leak.patch) > diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c > index 7225b6e..257c241 100644 > --- a/drivers/scsi/libiscsi.c > +++ b/drivers/scsi/libiscsi.c > @@ -1981,6 +1981,7 @@ void iscsi_pool_free(struct iscsi_pool *q) > kfree(q->pool[i]); > if (q->pool) > kfree(q->pool); > + kfree(q->queue); > } > EXPORT_SYMBOL_GPL(iscsi_pool_free); > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
