Hannes Reinecke wrote:
> Michał Mirosław wrote:
>> --- a/drivers/scsi/scsi_sysfs.c
>> +++ b/drivers/scsi/scsi_sysfs.c
>> @@ -872,12 +872,12 @@ int scsi_sysfs_add_sdev(struct scsi_device *sdev)
>> error = device_add(&sdev->sdev_gendev);
>> if (error) {
>> put_device(sdev->sdev_gendev.parent);
>> - printk(KERN_INFO "error 1\n");
>> + printk(KERN_ERR "sysfs: SCSI device registration failed: %d\n", error);
> Shouldn't that be sdev_printk()?
It seems it shouldn't. sdev_printk() wants device name and bus ID of
the sdev_gendev. AFAICS device_add() initializes them, and callers of
device_add() can't be quite sure how far device_add() got before an error.
>> return error;
>> }
>> error = device_add(&sdev->sdev_dev);
>> if (error) {
>> - printk(KERN_INFO "error 2\n");
>> + printk(KERN_ERR "sysfs: SCSI class device registration failed: %d\n", error);
> Same here ...
At that point, sdev_printk() should work indeed.
--
Stefan Richter
-=====-==--= ---= -==--
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
