Re: [PATCH4/5] mpt fusion: Optimized SendEventNotification [Resendig updated patch]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 10, 2009 at 04:12:39PM -0600, James Bottomley wrote:
> > +                       dinitprintk(ioc, printk(MYIOC_s_DEBUG_FMT "alt-ioc
> > +                               reply irq re-enabled\n",
> > +                               ioc->alt_ioc->name));
> 
> This isn't legal C: you can't split a string constant without a
> backslash:

Umm ... I don't think you can even split it with a backslash.  You need
to use string concatenation like so:

			dinitprintk(ioc, printk(MYIOC_s_DEBUG_FMT "alt-ioc "
				"reply irq re-enabled\n",
				ioc->alt_ioc->name));

Or, since it's 100% more readable and greppable:

			dinitprintk(ioc, printk(MYIOC_s_DEBUG_FMT
				"alt-ioc reply irq re-enabled\n",
				ioc->alt_ioc->name));

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux