On Fri, 2009-01-09 at 13:03 -0800, Andrew Morton wrote: > On Fri, 9 Jan 2009 21:58:35 +0100 > Martin Michlmayr <tbm@xxxxxxxxxx> wrote: > > > * akpm@xxxxxxxxxxxxxxxxxxxx <akpm@xxxxxxxxxxxxxxxxxxxx> [2009-01-09 12:28]: > > > The ACARD driver calls udelay() with a value > 2000, which leads to > > > to the following compilation error on ARM: > > > ERROR: "__bad_udelay" [drivers/scsi/atp870u.ko] undefined! > > > make[1]: *** [__modpost] Error 1 > > > Fix this by using a combination of mdelay and udelay. > > > > James already said that this patch is wrong, > > Well, it's not "wrong" - it has no runtime effect - it just fixes the build. It's wrong to silence a warning or build break while keeping the effect it was complaining about it's hiding a bug. Now if the warning is wrong, we can take it out of the ARM build ... but I've got to say it looks right: the udelay in this driver will lock a UP system solid for 2ms. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
