This patch fixes two bugs: 1) rmmod sym53c8xx uses shost after freeing it with scsi_put_host(shost). 2) insmod sym53c8xx doesn't call scsi_put_host(shost) if scsi_add_host() fails, causing a memory leak on the error path. Signed-off-by: Tony Battersby <tonyb@xxxxxxxxxxxxxxx> --- previously posted here: http://marc.info/?l=linux-scsi&m=122945812727396&w=4 --- linux-2.6.28/drivers/scsi/sym53c8xx_2/sym_glue.c.orig 2009-01-07 17:30:06.000000000 -0500 +++ linux-2.6.28/drivers/scsi/sym53c8xx_2/sym_glue.c 2009-01-07 17:31:07.000000000 -0500 @@ -1660,6 +1660,7 @@ static int sym_detach(struct Scsi_Host * OUTB(np, nc_istat, 0); sym_free_resources(np, pdev); + scsi_host_put(shost); return 1; } @@ -1749,7 +1750,6 @@ static void sym2_remove(struct pci_dev * struct Scsi_Host *shost = pci_get_drvdata(pdev); scsi_remove_host(shost); - scsi_host_put(shost); sym_detach(shost, pdev); pci_release_regions(pdev); pci_disable_device(pdev); -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
