Boaz Harrosh wrote: > Randy Dunlap wrote: >> Boaz Harrosh wrote: >>> Kconfig file for the drivers/scsi/osd subdirectory. >>> Adds the following config items: >>> config SCSI_OSD_INITIATOR >>> config SCSI_OSD_ULD >>> config SCSI_OSD_DPRINT_SENSE >>> config SCSI_OSD_DEBUG >>> >>> Signed-off-by: Boaz Harrosh <bharrosh@xxxxxxxxxxx> >>> Reviewed-by: Benny Halevy <bhalevy@xxxxxxxxxxx> >>> --- >>> drivers/scsi/osd/Kconfig | 53 ++++++++++++++++++++++++++++++++++++++++++++++ >>> 1 files changed, 53 insertions(+), 0 deletions(-) >>> create mode 100644 drivers/scsi/osd/Kconfig >>> >>> diff --git a/drivers/scsi/osd/Kconfig b/drivers/scsi/osd/Kconfig >>> new file mode 100644 >>> index 0000000..861b5ce >>> --- /dev/null >>> +++ b/drivers/scsi/osd/Kconfig >>> @@ -0,0 +1,53 @@ >>> +# >>> +# Kernel configuration file for the OSD scsi protocol >>> +# >>> +# Copyright (C) 2008 Panasas Inc. All rights reserved. >>> +# >>> +# Authors: >>> +# Boaz Harrosh <bharrosh@xxxxxxxxxxx> >>> +# Benny Halevy <bhalevy@xxxxxxxxxxx> >>> +# >>> +# This program is free software; you can redistribute it and/or modify >>> +# it under the terms of the GNU General Public version 2 License as >>> +# published by the Free Software Foundation >>> +# >>> +# FIXME: SCSI_OSD_INITIATOR should select CONFIG (HMAC) SHA1 somehow. >>> +# How is it done properly? >> Probably similar to how net/sctp/Kconfig does it: >> >> select CRYPTO >> select CRYPTO_HMAC >> select CRYPTO_SHA1 >> > > It is not yet relevant, I have not submitted the security code. > But thanks, that looks doable. I have a question? > When you do select, you must manually select the fixture you need plus > all it's dependencies and their dependencies recursively, parents first? 'select' does not follow any dependency chains, so you need to select all of them yourself. I don't know that "parents first" is required. -- ~Randy -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
