>>>>> "James" == James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> writes: James> We already show the power of 10 size as GiB ... how does the James> IDEMA spec actually differ from that? The intent was for the capacity printed to be exactly the same number as on the drive label. James> It's one thing to display the truth in a more positive light (as James> in use power of 10 GiB etc.) it's quite another to display James> incorrect sizes ... is the IDEMA spec just optimistic but not James> unreasonable rounding, or is it actually inflating sizes wrongly? It's slightly deflating the capacity compared to power of 10. For new drives that adhere to the IDEMA spec it's about 0.02%. For older drives with "proprietary" LBA counts the difference is bigger. I tested the patch on a few SCSI drives before sending it out. They went from being printed as 73.4 GB to 73GB. However, I just collected data from a bunch of recent drives and there it doesn't make a difference at all thanks to your rounding in string_get_size(). So maybe just drop this for now. The code was initially done for a different project. I applied it to sd.c because I could and it made a difference in my initial test case. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
