>>>>> "Matthew" == Matthew Wilcox <matthew@xxxxxx> writes: >> + BUG_ON(dif && (scmd->cmnd[0] == READ_6 || scmd->cmnd[0] == >> WRITE_6)); Matthew> This BUG_ON gave me a 'Huh?' moment. I immediately wondered if Matthew> it was user-triggerable. The answer is "no, this is kosher". Matthew> sd_dif_op() is only called from sd.c where it has chosen which Matthew> READ_*/WRITE_* opcode to set up, and it would indeed be an Matthew> internal bug for this combination of conditions to exist. Yep, I recently had to track down a bug where we had accidentally (for completely different reasons) switched to 6-byte commands. The code in the completion path that triggered this condition is now gone, thanks to Alan. But I left the BUG_ON in place because it was no fun track this down. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
