>>>>> "Matthew" == Matthew Wilcox <matthew@xxxxxx> writes:
Matthew> Of course, it's entirely legitimate for devices to not
Matthew> implement READ CAPACITY 16, so this patch also includes a
Matthew> fallback to READ CAPACITY 10 for SCSI-3 devices.
I've been running with this on my DIF drives for a few days and
everything looked fine.
Tonight I tried an all-spindles-in-the-lab test. I have several drives
that report SCSI_3 but don't implement READ CAPACITY(16). All of them
correctly send sense error back. That's the good news.
The bad news is that I have one particular drive model that after a
failed READ CAPACITY(16) command responds correctly to READ
CAPACITY(10). And *then* the drive firmware commits suicide.
FWIW, this is 2Gbps/10Krpm FC kit. So not USB/FireWire and not exactly
90s gear either.
*sigh*
At least for DIF I have an innocuous INQUIRY field to key off of. Long
term I think we should check the Block Limits thin provisioning bits.
For now may I suggest a much more conservative approach:
- if (sdp->scsi_level > SCSI_2) {
+ if (scsi_device_protection(sdp) || sdp->scsi_level > SCSI_SPC_2) {
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
