On Sun, 21 Dec 2008, Stefan Richter wrote:
> Alan Stern wrote:
> > --- usb-2.6.orig/include/scsi/scsi_device.h
> > +++ usb-2.6/include/scsi/scsi_device.h
> > @@ -142,6 +142,7 @@ struct scsi_device {
> > unsigned select_no_atn:1;
> > unsigned fix_capacity:1; /* READ_CAPACITY is too high by 1 */
> > unsigned guess_capacity:1; /* READ_CAPACITY might be too high by 1 */
> > + unsigned check_capacity:1; /* Verify READ_CAPACITY result */
>
> Maybe add "ignored if no USB_STORAGE support is built" to the comment
> since it is a no-op otherwise:
Yes. As it happens I wrote this comment before writing the rest of the
patch, and the "#if" protection around the code was an afterthought.
In practice, if other transports can make use of this test then the
"#if" can be removed.
Since only one or two firewire/ieee1394 devices have the FIX_CAPACITY
quirk, it didn't look like you'd be very interested in using the test.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
