On Thu, Dec 18, 2008 at 04:38:28PM +0200, Boaz Harrosh wrote: > OK Then I say D, go to T10, while white list the (0) devices that currently > report !SCSI_3 but do support UNMAP. These are only USB right? I'm not sure I've explained myself correctly. - There are new features from T10 (UNMAP being one of them) that are reported only through the RC16 command. - We don't currently use RC16 unless: - The device claims to have more than 4 billion sectors (~= 2TB with 512-byte sectors) OR - The device claims to support protection information We need a way to be able to use RC16, or we need to persuade T10 that using RC16 is basically impossible in the real world, so they should stop putting features in it. James and I seem to have come to a conclusion -- that we'll try RC16 for drives which claim SCSI_3 compliance (which excludes all the current USB devices). It's then up to the USB people to implement a whitelist for not mangling USB devices down to SCSI_2. > Your tested devices report SCSI_3? Do all devices that are scsi_level > SCSI_2 > suppose to support RC16? My tested devices are all libata which claims SCSI_SPC_2 compliance. Obviously, this is faked. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html