Re: [PATCH] sd: tell the user when a disk's capacity is adjusted

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Montag, 15. Dezember 2008 16:32:59 schrieb Alan Stern:
> +           (sdp->guess_capacity && (sdkp->capacity & 0x01))) {
> +               sd_printk(KERN_INFO, sdkp, "Adjusting the sector count "
> +                               "from its reported value: %llu\n",

Maybe this is just me, but if the disk actually has an odd number of sectors
this code will assume the disk is one sector too big. Therefore we should
still learn about buggy enclosures and add them to the list, so we should
make a difference between known buggy devices and cases the heuristics
works, particularly as it may mark a rare cases where a working device
is truncated. So KERN_INFO seems a bit weak.

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux