On Fri, 5 Dec 2008 11:53:09 +0100 Olaf Hering <olh@xxxxxxx> wrote: > On Thu, Dec 04, FUJITA Tomonori wrote: > > > On Wed, 3 Dec 2008 15:58:57 +0100 > > Olaf Hering <olh@xxxxxxx> wrote: > > > > > > > > change init order to fix crash due to uninitalized shost_data > > > > I think that calling crq_queue_create leads to the creation of a rport > > so we need to set up everything before that. The current code is racy. > > > > > > > No idea if the patch is correct. > > > > Almost correct, I think. Needs to modify the error handling > > too. Probably, it would be better to call scsi_tgt_alloc_queue before > > crq_queue_create. > > > > How about this? > > Yes, that works for me. Thanks! > Would be nice to get this into 2.6.28 to avoid a crash. Yeah, hopefully we can. I'll resend this with a proper description. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
