On Wed, 2008-11-26 at 18:46 +0100, Bernd Schubert wrote: > Activate the error handler if DID_SOFT_ERROR failed to often, but only > for commands which have a scmd->allowed > 1. > Also make a function out of a goto-block. What is the rationale for this? It really doesn't look right since DID_SOFT_ERROR is supposed to be for temporary out of resource conditions in the HBA driver ... activating the error handler isn't really going to fix this because the eh is taking us through a state model for device conditions, which DID_SOFT_ERROR shouldn't be. If you just need a DID_FAIL to activate the eh, it can be added without changing the meaning of DID_SOFT_ERROR. Also, you changed the return to make it device blocking (which also doesn't look right) but didn't document that in the change log. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
