On Tue, 25 Nov 2008, James Bottomley wrote: > On Tue, 2008-11-25 at 10:34 -0500, Alan Stern wrote: > > This patch is intended for 2.6.27.stable and 2.6.28. It's a temporary > > fix for a problem affecting a number of USB mass-storage devices > > (including many Nokia phones): When trying to access a nonexistent > > "last" sector, the SCSI midlayer gets caught in an endless retry loop. > > Can't we just invoke the last sector handling flag for all Nokia > devices? That would work for those devices... until and unless Nokia ever decides to correct their bug. It won't help anything else. > This would cause tape errors on unit attention (fairly common > condition). It can be argued that we get more users of USB mobile > phones than tapes, but I'd rather keep both communities happy Me too. I realize this patch hasn't been tested or vetted by anyone in the SCSI development crowd. That's why I've been pestering you guys about it! > By and large, the reason we backport from head if at all possible is so > we can avoid bugs like this creeping into stable. (And backporting from > head is far easier if the bug fixes are small and don't contain > miscellaneous code clean ups, control flow changes and comment fixes) > I tried to untangle it on the 'plane yesterday. I've just got a bit > more testing to do then I'll post the patch to your patch. That's fine with me. I just don't want to see the same problem continuing on into 2.6.28.final. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html