Hi James, thanks for the rework, looks pretty good two me :) One first question below. James Smart wrote: <snip> > + /* fc_host Message Codes */ > +#define FC_BSG_HST_ADD_RPORT (FC_BSG_HST_MASK | 0x00000001) > +#define FC_BSG_HST_DEL_RPORT (FC_BSG_HST_MASK | 0x00000002) > +#define FC_BSG_HST_ELS_NOLOGIN (FC_BSG_HST_MASK | 0x00000003) > +#define FC_BSG_HST_VENDOR (FC_BSG_HST_MASK | 0x000000FF) > + Shouldn't we add FC_BSG_HST_CT_NOLOGIN as well? As far as I can see from looking over the patch (correct me when I am wrong), the way to issue a CT request now is to send an FC_BSG_HST_ADD_RPORT for the wka port in question (if not enumerated by the driver, which zfcp does not do), then send the FC_BSG_RPT_CT followed by a FC_BSG_HST_DEL_RPORT. I was under the impression the CT stuff was one of the main reasons to have devices for the fc_host. What do you think? > + /* fc_rport Message Codes */ > +#define FC_BSG_RPT_ELS (FC_BSG_RPT_MASK | 0x00000001) > +#define FC_BSG_RPT_CT (FC_BSG_RPT_MASK | 0x00000002) > + </snip> Sven -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
