On Sat, Nov 15, 2008 at 09:11:20PM -0500, Douglas Gilbert wrote:
> Andi Kleen wrote:
> >Instead of using GFP_DMA directly.
> >
> >Also I stubbed SG_SET_FORCE_LOW_DMA ioctls which don't make any sense
> >because the kernel should always use the correct values on its own.
>
> You propose removing a define from a public interface and thereby
> might break existing code. A comment in sg.h might be appropriate.
Hmm, I assume those SG_SET_FORCE_* defines are only used
in the kernel. Is there a realistic case where user space
could use them or are just just talking in general, objecting
to any change outside #ifdef __KERNEL__ ?
> Something that might trip:
> find <kernel_src_tree> -name '*.[hc]' -exec \
> grep SG_SET_FORCE_LOW_DMA {} \; -print
>
> when the compiler gets upset.
I did that of course (using id-utils) and there were no users in tree.
-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
