On Wed, Nov 05, 2008 at 12:46:12PM -0500, James Bottomley wrote: > On Tue, 2008-11-04 at 16:35 +0100, Christof Schmitt wrote: > > plain text document attachment (fix-status-read-alloc.diff) > > From: Christof Schmitt <christof.schmitt@xxxxxxxxxx> > > > > When allocating fsf requests without qtcb, store the pointer to the > > mempool in the fsf requests for later call to mempool_free. This > > codepath is only used by the status_read requests. > > > > Signed-off-by: Christof Schmitt <christof.schmitt@xxxxxxxxxx> > > Signed-off-by: Swen Schillig <swen@xxxxxxxxxxxx> > > I put this one in, but can you explain this last signoff better? You > sent me the patch, so your signoff should appear last. If Swen altered > the patch, his signoff should appear before yours (with a small > explanation of the alteration in square brackets). If he's just > approving it, it should be Acked-by: not Signed-off-by: I wrote the patch, Swen reviewed it and i sent it as part of the patch series. It looks like this did not follow the exact guidelines. For future patches, i will document the review with the "Acked-by:". Christof -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
