http://bugzilla.kernel.org/show_bug.cgi?id=11898 ------- Comment #24 from yanmin_zhang@xxxxxxxxxxxxxxx 2008-11-05 18:06 ------- (In reply to comment #18) > (In reply to comment #16) > > Alex, > > > > Your patch is not optimized. > > What do you mean exactly? > Scenario: starved_list consists of 5 sdev. The 1st/2nd/3rd/4th sdev make "if (blk_queue_tagged(q) && !blk_rq_tagged(req))" true, so they are added back, but the 5th sdev is ok to be processes and deleted from starved_list. With Alex's patch, scsi_run_queue will check all the 4 sdev again. I don't how possible the scenario happens. If it happens very rarely, Alex's patch is ok. I just speak theoretically. -- Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
