Am Donnerstag, 30. Oktober 2008 15:01:13 schrieb James Bottomley: > On Thu, 2008-10-30 at 13:09 +0100, Oliver Neukum wrote: > > >From reading the SCSI spec it seems that having the valid bit 0 (0x70 > > checked in scsi_sense_valid) should does not invalidate the ASC or ASQ. > > [See page 37 of spc4r02.pdf]. > > That's a correct reading of the spec as regards the valid bit for non > descriptor sense data, but not applicable to this situation. sense_valid > is generated from (byte[0] & 0x70 == 0x70) (see scsi_sense_valid() in > include/scsi/scsi_eh.h) not from the valid bit. This test is *required* > by the standard otherwise what we have isn't sense data. > > > It should only invalidate the INFORMATION > > field. Therefore remove the sense_valid check from the USB quirk. > > > > This is needed for a strange USB storage device. > > Could you elaborate a bit more? What's its problem (and what is it > replying as byte 0 to a REQUEST_SENSE)? I got a report about a storage device that reports 0x28 and scsi_sense_valid() returns false. > > Signed-off-by: Brandon Philips <bphilips@xxxxxxx> > > Signed-off-by: Oliver Neukum <oneukum@xxxxxxx> > > These signoffs don't make sense for what you sent ... this implies that > its Brandon's patch which you altered, in which case it needs a From: at > the beginning to make him the author. I wrote it. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
