Re: [patch 14/17] scsi: fix bad use of udelay in atp870u.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 29 Oct 2008 16:42:15 -0500
James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote:

> On Wed, 2008-10-29 at 14:24 -0700, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> > -       udelay(0x800);
> > +       mdelay(2);
> > +       udelay(48);
> 
> OK, this fix is obviously wrong ... the code holds off interrupts for
> two ticks that's clearly completely bogus.  In this case silencing the
> warning is hiding the bogosity ... now if only someone could actually
> fix it ...
> 

That'll take some heavy lifting.  There's an mdelay(128) a few lines up!

I'd suggest that you merge this to fix the ARM build then hurriedly
find something else to look at :(

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux