Re: [PATCH] block: optimizations in blk_rq_timed_out_timer()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jens Axboe [jens.axboe@xxxxxxxxxx] wrote:
> > Yes, we should not access it although I don't think the request can be
> > freed while the existing code is accessing the deadline field. What 
> > likely can happen is that we may call mod_timer with jiffies that is
> > older than current which would call the timer immediately...
> 
> That would not call the timer immediately, that will not call it until
> jiffies reaches that value again. So you're looking at a minimum of 49
> days :-)

I remember the timer code treating "past" expiry times as special. If
not, then we have a real bug! It is also hard to guarantee in
blk_rq_timed_out_timer() that we always call mod_timer with future
expiry time!

--Malahal.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux