Re: [PATCH v2] SCSI: detect missing data for INQUIRY

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 28 Oct 2008, James Smart wrote:

> Checking the payload like this is really hokey - but probably works.

I agree completely; it _is_ hokey.  There is precedent, however -- 
scsi_mode_sense() behaves similarly.

> Have we lost all notion from the LLDD on what the actual payload length 
> was (calculated by expected transfer length and resid) ?

In short: Yes, we have.  That information is discarded by
scsi_execute().

>  Seems like a 
> much better idea than just checking contents.

Again I agree.  The SCSI midlayer simply is not designed around the
idea of LLD's returning an actual transfer length.  I have no idea why
not -- I wasn't there when the SCSI core was initially designed.  :-)

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux