Chris Leech wrote: > On Thu, Sep 11, 2008 at 1:03 AM, Boaz Harrosh <bharrosh@xxxxxxxxxxx> wrote: >>> diff --git a/fs/jfs/endian24.h b/fs/jfs/endian24.h >>> index fa92f7f..45b6397 100644 >>> --- a/fs/jfs/endian24.h >>> +++ b/fs/jfs/endian24.h >>> @@ -33,6 +33,9 @@ >>> ((__x & (__u32)0x00ff0000UL) >> 16) )); \ >>> }) >>> >>> +#undef __cpu_to_le24 >>> +#undef __le24_to_cpu >>> + >> Does #undef also work on inline functions? I didn't know that > > No, it doesn't and those two lines don't do anything. The two below > do, so this file gets touched anyway, and the JFS patch deletes the > entire file. I'll fix this is there's some other reason to redo the > patchset again. > Sorry my bad, yes they get removed one patch later. No need to resubmit just for that I think >>> #if (defined(__KERNEL__) && defined(__LITTLE_ENDIAN)) || (defined(__BYTE_ORDER) && (__BYTE_ORDER == __LITTLE_ENDIAN)) >>> #define __cpu_to_le24(x) ((__u32)(x)) >>> #define __le24_to_cpu(x) ((__u32)(x)) >>> @@ -42,6 +45,8 @@ >>> #endif >>> >>> #ifdef __KERNEL__ >>> + #undef cpu_to_le24 >>> + #undef le24_to_cpu >>> #define cpu_to_le24 __cpu_to_le24 >>> #define le24_to_cpu __le24_to_cpu >>> #endif Thanks again for doing this Reviewed-by: Boaz Harrosh <bharrosh@xxxxxxxxxxx> on all patches -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
