On Wed, 10 Sep 2008 01:07:50 -0700 (PDT) bugme-daemon@xxxxxxxxxxxxxxxxxxx wrote: > http://bugzilla.kernel.org/show_bug.cgi?id=11529 > > Summary: aacraid - WARNING: at lib/scatterlist.c > Product: SCSI Drivers > Version: 2.5 > KernelVersion: 2.6.26.5 > Platform: All > OS/Version: Linux > Tree: Mainline > Status: NEW > Severity: normal > Priority: P1 > Component: AACRAID > AssignedTo: scsi_drivers-aacraid@xxxxxxxxxxxxxxxxxxxx > ReportedBy: winfried@xxxxxxxxxxx > > > Latest working kernel version: 2.6.25.17 > Earliest failing kernel version: 2.6.26 > Distribution: Debian > Hardware Environment: Intel 686 > Problem Description: > > During boot I see 16 warnings about scatterlist.c, right after the > initiantion of aacraid (Using a Adeptec AAR-2410SA raid card). Boot > seems to proceed normally. After the boot I don't see these messages > anymore: > > [ 5.640780] AAC0: kernel 4.2-0[8205] Aug 17 2005 > [ 5.640780] AAC0: monitor 4.2-0[8205] > [ 5.640780] AAC0: bios 4.2-0[8205] > [ 5.640780] AAC0: serial C92A77 > [ 5.640781] scsi2 : aacraid > [ 5.641921] ------------[ cut here ]------------ > [ 5.641924] WARNING: at lib/scatterlist.c:316 sg_copy_buffer+0x2e/0x14f() > [ 5.641926] Modules linked in: pata_marvell(+) ata_piix(+) ohci1394(+) > libata ieee1394 aacraid scsi_mod dock ehci_hcd uhci_hcd usbcore e1000e thermal > processor fan thermal_sys Sorry about the bug. I thought that this function was called with local interrupts disabled since in 2.6.25 this uses KM_IRQ0 without disabling local interrupts... This fix needs to go to scsi-rc-fixes. = From: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> Subject: [PATCH] aacraid: disable local interrupts before scsi_sg_copy APIs Signed-off-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> CC: stable@xxxxxxxxxx --- drivers/scsi/aacraid/aachba.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c index aa4e77c..8e60d06 100644 --- a/drivers/scsi/aacraid/aachba.c +++ b/drivers/scsi/aacraid/aachba.c @@ -404,13 +404,16 @@ static void get_container_name_callback(void *context, struct fib * fibptr) char d[sizeof(((struct inquiry_data *)NULL)->inqd_pid)]; int count = sizeof(d); char *dp = d; + unsigned long flags; do { *dp++ = (*sp) ? *sp++ : ' '; } while (--count > 0); + local_irq_save(flags); scsi_sg_copy_to_buffer(scsicmd, &inq, sizeof(inq)); memcpy(inq.inqd_pid, d, sizeof(d)); scsi_sg_copy_from_buffer(scsicmd, &inq, sizeof(inq)); + local_irq_restore(flags); } } -- 1.5.5.GIT -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
