Re: [PATCH 11/15] lpfc 8.2.8 : Update driver to use new Host byte error code DID_TRANSPORT_DISRUPTED

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



James Bottomley wrote:
On Sun, 2008-08-24 at 21:50 -0400, James Smart wrote:
Update driver to use new Host byte error code DID_TRANSPORT_DISRUPTED.

This patch depends pending upstream patches described in:
http://marc.info/?l=linux-scsi&m=121263014808604&w=2

Particularly:
http://marc.info/?l=linux-scsi&m=121263014908607&w=2
which defines DID_TRANSPORT_DISRUPTED.

This patch supercedes the lpfc patch in that series:
http://marc.info/?l=linux-scsi&m=121263015008616&w=2

I've got this one, but only partially.  The third hunk doesn't apply:


It is ok and better to drop this part below for target busy. If we return target busy in the queuecommand then the we will block it right away. If we return DID_TRANSPORT_DISRUPTED then it will not get blocked until the soft irq processes the command, which is a waste.


--- 1072,1078 ----
  	 * transport is still transitioning.
  	 */
  	if (!ndlp || !NLP_CHK_NODE_ACT(ndlp)) {
+ 		cmnd->result = ScsiResult(DID_TRANSPORT_DISRUPTED, 0);
  		goto out_fail_command;
  	}

It became a goto out_target_busy, which returns SCSI_MLQUEUE_TARGET_BUSY
via a patch which you acked.


Sorry about that. We were not sure which parts of which patchset you were going to take so some wires got crossed.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux